Automatically build and push image to Docker Hub when new tag is pushed #1386
Conversation
.github/workflows/build-image.yml
Outdated
| on: | ||
| push: | ||
| tags: | ||
| - '*' |
There was a problem hiding this comment.
does this mean that it'll only build if we make a tag? What about making it a bit more specific? Can we ensure that the tag is formatted correctly?
There was a problem hiding this comment.
Yes, it'll only build and push the image on a tag. Yes, I think it supports regex so we can restrict the build to properly formatted tags.
There was a problem hiding this comment.
We can do something like v-[0-9]{4}-[0-9]{2}-[0-9]{1,2}.[0-9]+ instead of * to trigger the workflow only if the tag matches the regex.
| - name: Build and push image | ||
| # Github stores the current tag in an enviroment variable (GITHUB_REF) in the format /refs/tags/TAG_NAME. | ||
| # Using shell parameter expansion, we extract the TAG_NAME. | ||
| run: ./docker/push.sh 'prod' "${GITHUB_REF/refs\/tags\//}" |
There was a problem hiding this comment.
I opened a ticket about improving push.sh to make it fail properly if any intermediate process fails (e.g. don't push if the build fails). Maybe we could include that here? (although I guess the push will fail also if the build fails, because the tagged version won't exist)
|
this is super cool! |
| on: | ||
| push: | ||
| tags: | ||
| - 'v-[0-9]{4}-[0-9]{2}-[0-9]{1,2}.[0-9]+' |
There was a problem hiding this comment.
I would think it should be \. instead of . but the semver example in the docs says otherwise,
There was a problem hiding this comment.
it looks like they're patterns, not regexes, so the guidelines are probably correct.
Our deployment workflow is a bit convoluted. One step in simplifying the deployment is to automate building of docker images. Hence, adding an actions workflow for it.